adjust uses of eq? that should be object=? or object-or-false=?
#361
+90
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The framework and drracket tests all pass with these changes. |
Member
|
These changes look good as far as I can tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered thanks to the improved contracts (whose performance is still an ongoing concern) discussed in racket/draw#51, there are a number of
eq?tests that should actually be using object-based comparisons.This is an attempt to adjust them. This version passes all of the tests in
tests/gracketthat I know how to run and the DrRacket racket tests also seem to be passing (I'll check back in here when they've finished).