Update more deps #6057
Update more deps #6057
Conversation
| username = "0.2" | ||
| # We cannot upgrade to utoipa 5.0+ due to significant breaking changes: | ||
| # 1. The `OpenApi` struct structure changed (fields are private), breaking our manual merging logic in openapi.rs | ||
| # in `quickwit-serve`. This code is fundamentally incompatible with version 5.x. |
There was a problem hiding this comment.
Here is a PR that tried to upgrade utoipa to 5.0:
https://github.com/quickwit-oss/quickwit/pull/6058/changes with a lot of changes.
| "hex", | ||
| "http 1.4.0", | ||
| "ring 0.17.14", | ||
| "ring", |
There was a problem hiding this comment.
Cool! A PR that removes dependencies 👍
|
|
||
| use rand::distributions::Alphanumeric; | ||
| use rand::prelude::*; | ||
| use rand_distr::Alphanumeric; |
There was a problem hiding this comment.
why not rand::distr::Alphanumeric?
https://docs.rs/rand/latest/rand/distr/struct.Alphanumeric.html
quickwit/quickwit-common/Cargo.toml
Outdated
| pnet = { workspace = true } | ||
| prometheus = { workspace = true } | ||
| rand = { workspace = true } | ||
| rand_distr = { workspace = true } |
There was a problem hiding this comment.
This might not be necessary.
rand::distr seem to have the essentials. The advanced distributions like LogNormal are not in there but I suspect we only use those for tests (so that's a dev-dependencies)
There was a problem hiding this comment.
sounds good, Removed.
fulmicoton-dd
left a comment
fulmicoton-dd
left a comment
There was a problem hiding this comment.
Good job! Can you see if you can reduce the use of rand_distr to dev dependencies?
* update otl and rand family deps * update lindera family * update 3rd party license * fix tests * update the deps * fix fmt * uodate 3rd license * update gcp deps family * update 3rd party license * upgrade gcp * update the gcp deps * update tabled version * update tabled * update the logic * remove no-fail-fast * update console subscriber * fix fmt * add resource back * add shutdown to trace_provider * remove comments * add the comment * fix fmt * update lindera family deps * add comments for lindera family * update tikv family * update nom dep * update deps * update 3rd party license * add comments for utoipa * address comments * address comments * address comments * update 3rd party file * update lint
Description
Update more deps by running:
How was this PR tested?