Fixing sinter post-selection feature#1002
Open
shohamjac wants to merge 2 commits intoquantumlib:mainfrom
Open
Conversation
Contributor
Author
|
Hi Craig, I think the failed test is due to the new python version which you already fixed. is there a reason not to merge this? |
DeDuckProject
approved these changes
Feb 26, 2026
| @@ -1,4 +1,5 @@ | |||
| import collections | |||
| from importlib.metadata import metadata | |||
Contributor
There was a problem hiding this comment.
is this used anywhere?
| assert 1 <= d[0.04].errors <= 100 | ||
|
|
||
| def test_collect_postselection(): | ||
| def postselect_all_detectors_predicate(index: int, metadata: any, coords: tuple) -> bool: |
Contributor
There was a problem hiding this comment.
Suggested change
| def postselect_all_detectors_predicate(index: int, metadata: any, coords: tuple) -> bool: | |
| def postselect_all_detectors_predicate(_index: int, _metadata: any, _coords: tuple) -> bool: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from sinter 1.14
sinter.collectwith postselection is raising the following error:An example can be seen here.
I have fixed the assertion (
predictions.shape[0] != num_shots - num_discards_1) and added a post-selection testtest_collect_postselection.