FROMLIST: arm64: dts: qcom: monaco: Enable SDHCI storage support#338
Open
mchunara007 wants to merge 3 commits intoqualcomm-linux:qcom-6.18.yfrom
Open
FROMLIST: arm64: dts: qcom: monaco: Enable SDHCI storage support#338mchunara007 wants to merge 3 commits intoqualcomm-linux:qcom-6.18.yfrom
mchunara007 wants to merge 3 commits intoqualcomm-linux:qcom-6.18.yfrom
Conversation
… board DT The Monaco SoC SDHC controller supports both eMMC and SD cards. However, the 'supports-cqe' property (Command Queue Engine) is specific to eMMC and conflicts with SD card operation. Remove 'supports-cqe' from the SoC device tree to ensure compatibility with SD cards. Simultaneously, add the property explicitly to the qcs8300-ride board device tree, as this board uses the controller in eMMC mode. This ensures the SoC definition remains generic while enabling features correctly at the board level. Signed-off-by: Monish Chunara <[email protected]>
…overlay The monaco EVK board supports either eMMC or SD-card, but only one can be active at a time. Enable the SD Host Controller Interface (SDHCI) on the monaco EVK board to support SD Card for storage via a device tree overlay. This allows eMMC support to be enabled through a separate overlay when required. Signed-off-by: Monish Chunara <[email protected]>
…a overlay Enable the SDHCI controller for eMMC functionality on the Monaco EVK using a device tree overlay. Configure the corresponding VCC regulator parameters to support the eMMC interface. Additionally, disable the UFS controller node. The VCC regulator is shared between the UFS and eMMC subsystems; leaving UFS enabled while operating eMMC results in power leakage on the shared rail. Signed-off-by: Monish Chunara <[email protected]>
shashim-quic
requested changes
Mar 9, 2026
shashim-quic
left a comment
shashim-quic
left a comment
There was a problem hiding this comment.
Add Link: tag to commit log pointing to lore. Refer other commits how they add.
If you are using b4 then -l option automatically adds it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This series enables SDHCI storage support for both SD Card and eMMC on the
Qualcomm Monaco EVK platform.
The Monaco SoC shares the SDHCI controller between SD Card and eMMC use
cases. Previously, the common SoC dtsi unconditionally enabled the
'supports-cqe' property. This causes regression for SD cards, resulting
in timeouts and initialization failures during the probe sequence, as
the driver attempts to enable Command Queueing (CQE) logic incompatible
with the SD protocol.
To resolve this and enable full storage support, this series:
now only enabled in the specific eMMC configuration where it is
supported.
also explicitly disables the UFS controller to prevent power leakage,
as the VCC regulator is shared between the UFS and eMMC rails on this
platform.
Validated on Qualcomm Monaco EVK with both SD Card and eMMC modules.