Add tidy fixes #5268
Closed
Add tidy fixes #5268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyyever
force-pushed
the
more_tidy9
branch
7 times, most recently
from
95af750 to
e66ebc0
Compare
Contributor
|
Hi @cyyever can I trouble you to remove the structured bindings, since they cause compilation issues at least on internal builds with "capturing a structured binding is not yet supported in OpenMP" error? |
Contributor
Author
|
@q10 I forgot they were removed by you. |
Signed-off-by: Yuanyuan Chen <[email protected]>
Contributor
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Dec 24, 2025
Summary: Apply more tidy fixes to gpu code. Differential Revision: D89737616 Pulled By: q10
Contributor
|
@cyyever can I trouble you to remove the |
cyyever
force-pushed
the
more_tidy9
branch
2 times, most recently
from
8d1370e to
fa3729c
Compare
Signed-off-by: Yuanyuan Chen <[email protected]>
Contributor
Author
|
@q10 fixed |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Jan 5, 2026
Summary: X-link: facebookresearch/FBGEMM#2277 Apply more tidy fixes to gpu code. Differential Revision: D90046367 Pulled By: q10
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply more tidy fixes to gpu code.