cursor in password field using set_cursor_position #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
pythops
reviewed
Dec 1, 2025
src/mode/station/auth/psk.rs
Outdated
|
|
||
| let inner_width = passkey_area.width.saturating_sub(2) as usize; | ||
| let pad_left = if inner_width > pass_len { | ||
| (inner_width - pass_len) / 2 |
Contributor
Author
There was a problem hiding this comment.
👀 safety first. Should be fixed!
pythops
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses: #96 and adds a visual cursor to the password area.
cursor_demo.mp4
Note: I manually calculate the cursor x position + padding. I couldn't see a easy way to use ratatui's center function because the cursor isn't a widget. I'm not super familiar with ratatui though so if there's a better way I can look into it.