[stdlib] Align Traversable joinpath and __truediv__ with CPython
#15108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbaker
force-pushed
the
submit/traversable-match-python
branch
from
8b05f66 to
e535776
Compare
This comment has been minimized.
This comment has been minimized.
dcbaker
force-pushed
the
submit/traversable-match-python
branch
from
c3bf20a to
91956d7
Compare
The CPython implementation accepts `str | os.PathLike[str]`, typeshed only accepts `str`. CPython 3.13 implementations: https://github.com/python/cpython/blob/59f247e43bc93c607a5793c220bcaafb712cf542/Lib/importlib/resources/abc.py#L104 https://github.com/python/cpython/blob/59f247e43bc93c607a5793c220bcaafb712cf542/Lib/importlib/resources/abc.py#L129
dcbaker
force-pushed
the
submit/traversable-match-python
branch
from
91956d7 to
4745c44
Compare
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CPython implementation accepts
str | os.PathLike[str], typeshed only acceptsstr.CPython 3.13 implementations:
https://github.com/python/cpython/blob/59f247e43bc93c607a5793c220bcaafb712cf542/Lib/importlib/resources/abc.py#L104 https://github.com/python/cpython/blob/59f247e43bc93c607a5793c220bcaafb712cf542/Lib/importlib/resources/abc.py#L129