gh-142414: Unify UNBOUND in Lib/concurrent/interpreters/_queues.py and Lib/concurrent/interpreters/_crossinterp.py. #142515
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note35
commented
Dec 10, 2025
|
|
||
|
|
||
| UNBOUND = _crossinterp.UnboundItem.singleton('queue', __name__) | ||
| _crossinterp.register_unbound(UNBOUND, 3) |
Contributor
Author
There was a problem hiding this comment.
We probably want to import "3" from _crossinterp.py?
Comment on lines
49
to
50
| UNBOUND = _crossinterp.UnboundItem.singleton('queue', __name__) | ||
| _crossinterp.register_unbound(UNBOUND, 3) |
Member
There was a problem hiding this comment.
This seems very hacky. Couldn't we just import UNBOUND from _crossinterp and directly use it?
Contributor
Author
There was a problem hiding this comment.
This can pass the test too.
I made a commit with this suggestion.
I am not sure the intention of a BOUND definition in _queues before, I guess a better repr? (But likely not needed?)
note35
changed the title
note35
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is aligned with bug reporter's observation.
Test with
./python -m test test_interpreters test_struct./python -m test test_interpreters test_structfails with: KeyError: concurrent.interpreters._queues.UNBOUND #142414