[3.13] gh-142315: Don't pass the "real path" of Pdb script target to system functions (GH-142371) #142498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystem functions (pythonGH-142371) * Pick target depending on preconditions * Clarify the news fragment * Add test capturing missed expectation. * Add more idiomatic safe realpath helper * Restore logic where existance and directoriness are checked on realpath. * Link GH issue to test. * Extract a function to check the target. Remove the _safe_realpath, now no longer needed. * Extract method for replacing sys_path, and isolate realpath usage there. * Revert "Extract method for replacing sys_path, and isolate realpath usage there." This reverts commit 855aac3. * Restore _safe_realpath. --------- (cherry picked from commit d716e3b) Co-authored-by: Bartosz Sławecki <[email protected]> Co-authored-by: Jason R. Coombs <[email protected]>
This was referenced Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick target depending on preconditions
Clarify the news fragment
Add test capturing missed expectation.
Add more idiomatic safe realpath helper
Restore logic where existance and directoriness are checked on realpath.
Link GH issue to test.
Extract a function to check the target. Remove the _safe_realpath, now no longer needed.
Extract method for replacing sys_path, and isolate realpath usage there.
Revert "Extract method for replacing sys_path, and isolate realpath usage there."
This reverts commit 855aac3.
(cherry picked from commit d716e3b)
Co-authored-by: Bartosz Sławecki [email protected]
Co-authored-by: Jason R. Coombs [email protected]