-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
gh-142466: Pixi package definitions for downstream use #142469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
ping @FFY00 @hugovk @lysnikolaou |
|
You need to update the branch to fix the CI. |
- switch cases on `PYTHON_VARIANT` - remove `minor_version` by using `python3` - remove runtime-only asan options
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Filipe Laíns <[email protected]>
Co-authored-by: Filipe Laíns <[email protected]>
Co-authored-by: Filipe Laíns <[email protected]>
FFY00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for working on this @lucascolley! This is PR looks great, and sets up to add other sanitizer variants.
The pixi limitation that requires us to have separate recipes for each variant (prefix-dev/pixi#4599) is unfortunate, but I think doable from a maintenance POV, given that we have a few people interested in this. We'll see how it translates in practice, and hope the feature request gets implemented in the meantime.
I opened prefix-dev/rattler-build#2047 regarding the version string that currently needs to be updated manually, but could be dirtermined from git, with additional information. But let's wait for the pixi jinja functions to get stabilized before adding them to our recipes.
I'll leave this PR open a couple days to give a bit more time for folks to give feedback, but otherwise, this looks good to go 😊
implementation for gh-142466, supporting numpy/numpy#30381 and scipy/scipy#24066.