Skip to content

Conversation

@lucascolley
Copy link

implementation for gh-142466, supporting numpy/numpy#30381 and scipy/scipy#24066.

@bedevere-app
Copy link

bedevere-app bot commented Dec 9, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@python-cla-bot
Copy link

python-cla-bot bot commented Dec 9, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@lucascolley
Copy link
Author

ping @FFY00 @hugovk @lysnikolaou

@StanFromIreland
Copy link
Member

You need to update the branch to fix the CI.

- switch cases on `PYTHON_VARIANT`
- remove `minor_version` by using `python3`
- remove runtime-only asan options
Co-authored-by: Hugo van Kemenade <[email protected]>
lucascolley and others added 2 commits December 10, 2025 17:45
Co-authored-by: Filipe Laíns <[email protected]>
Co-authored-by: Filipe Laíns <[email protected]>
Co-authored-by: Filipe Laíns <[email protected]>
Copy link
Member

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this @lucascolley! This is PR looks great, and sets up to add other sanitizer variants.

The pixi limitation that requires us to have separate recipes for each variant (prefix-dev/pixi#4599) is unfortunate, but I think doable from a maintenance POV, given that we have a few people interested in this. We'll see how it translates in practice, and hope the feature request gets implemented in the meantime.

I opened prefix-dev/rattler-build#2047 regarding the version string that currently needs to be updated manually, but could be dirtermined from git, with additional information. But let's wait for the pixi jinja functions to get stabilized before adding them to our recipes.

I'll leave this PR open a couple days to give a bit more time for folks to give feedback, but otherwise, this looks good to go 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants