Fix pylsp-rope compatibility with Jupyter Notebooks#36
Open
mcepl wants to merge 1 commit intopython-rope:mainfrom
Open
Fix pylsp-rope compatibility with Jupyter Notebooks#36mcepl wants to merge 1 commit intopython-rope:mainfrom
mcepl wants to merge 1 commit intopython-rope:mainfrom
Conversation
Implement guard clauses to handle virtual documents (notebook cells) safely: - Add is_virtual_document() helper to detect non-file URIs - Update get_resource() to return None for virtual documents - Add early returns in pylsp_code_actions() and pylsp_rename() hooks - Prevent rope operations on virtual documents that don't correspond to files This fixes the python-lsp-server notebook test failure where pylsp-rope was interfering with notebook cell handling by trying to treat virtual URIs as filesystem paths. Signed-off-by: Matěj Cepl <[email protected]>
mcepl
force-pushed
the
jupyter_notebooks
branch
from
21510ce to
e30a4d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement guard clauses to handle virtual documents (notebook cells) safely:
This fixes the python-lsp-server notebook test failure where pylsp-rope was interfering with notebook cell handling by trying to treat virtual URIs as filesystem paths.