Merged
Conversation
This allows plugins to perform some operations (e.g. terminating a daemon process or cleaning temporary resources) upon LSP server shutdown.
ccordoba12
approved these changes
Aug 25, 2025
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @dlax!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows plugins to perform some operations (e.g. terminating a daemon process or cleaning temporary resources) upon LSP server shutdown.
For instance, this could be useful for pylsp-mypy which currently already does some temporary file cleanup through an atexit hook but would also need to terminate mypy daemon when LSP exits in order to avoid dangling processes. See python-lsp/pylsp-mypy#88