Copy LAST_JEDI_COMPLETIONS to cell document so that completionItem/resolve will work#663
Merged
ccordoba12 merged 3 commits intopython-lsp:developfrom Aug 25, 2025
Merged
Conversation
completionItem/resolve will work
LAST_JEDI_COMPLETIONS to cell document so that completionItem/resolve will work
Member
|
Thanks @hjr265 for your contribution! It looks good to me, but I'd like @krassowski to review it because this could impact JupyterLab-LSP. |
Member
|
No objections from my side - looks like fine workaround, though I would also suggest adding a test in case if it needs to be reworked later on. |
Contributor
Author
|
Thanks @krassowski! Let me add a test for this. |
Contributor
Author
|
@ccordoba12 I have added a test. Please let me know if there is anything else. |
ccordoba12
approved these changes
Aug 25, 2025
Member
ccordoba12
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @hjr265!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's say I am running this LSP server with Ruff (for linting) and Jedi (for autocompletion, with eager off). I then open a notebook document with a few cells in it.
I open the document (and the cells) with the
notebookDocument/didOpenmethod.Now, I request completion using the method
textDocument/completionand receive the completion items as expected.So far, so good.
Now, if I attempt to resolve one of the completion items using the
completionItem/resolvemethod, I receive an empty array as a result.This issue occurs because PyLSP concatenates cells of notebook documents into a temporary document and then uses it to generate completion items. That temporary document has a "randomly" generated UUID as its URI. When generating completion items, the shared data "LAST_JEDI_COMPLETIONS" is stored on this temporary document.
However, when the client sends back any "completion item" to be resolved, it looks for "LAST_JEDI_COMPLETIONS" shared data on the actual cell document, where this shared data is not present, and the request to "resolve" fails.
This PR copies the "LAST_JEDI_COMPLETIONS" shared data from the temporary document to the cell document at the end of the "completion" request.