-
Notifications
You must be signed in to change notification settings - Fork 53
Nested containers #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Nested containers #704
Conversation
updates: - [github.com/crate-ci/typos: v1.29.9 → v1.30.0](crate-ci/typos@v1.29.9...v1.30.0) - [github.com/astral-sh/ruff-pre-commit: v0.9.7 → v0.9.9](astral-sh/ruff-pre-commit@v0.9.7...v0.9.9)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #704 +/- ##
==========================================
+ Coverage 89.27% 89.32% +0.04%
==========================================
Files 40 40
Lines 4820 4889 +69
==========================================
+ Hits 4303 4367 +64
- Misses 517 522 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tlambert03
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @ndxmrb
so sorry for the long delay. couple concerns about typing and error catching. we don't need to belabor them too much, if you can fix great, otherwise let me know.
|
@ndxmrb, I made some significant changes to this PR. The main thing that was holding me back here was the return type of create_widget (up here) ... it broke the clean pattern of having all UIFields returning a widget where you could be certain to query I know it's been so long so you might have forgotten/lost interest by now. So I'll give this a week or so before merging |
Hi @tlambert03,
restarting my work from #669 after the
ValuedContainerchanges.Still, some things are missing:
ValueWidgets andContainerWidgets. Does this belong totest_pydantic()intest_ui_field.py?Tried my best with the types again, hope it's okay that way.
Thanks for having a look!