Skip to content

Conversation

@kumaradityaapril
Copy link

  • Closes Use "long-wave" rather than "infra-red" to refer to thermal radiation. #2653
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file.
  • New code is fully documented.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned

This pull request standardizes terminology by using "longwave (thermal)"
instead of "infrared" when referring to thermal radiation in the Faiman
radiative temperature model. This is a documentation-only change and does
not affect behavior or the public API.

@AdamRJensen
Copy link
Member

The current PR does not address the problem described (variable naming).

Closing this PR as it should be addressed by someone who's familiar with pvlib.

@kumaradityaapril
Copy link
Author

I appreciate the explanation; I get it. Thank you for the review and advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use "long-wave" rather than "infra-red" to refer to thermal radiation.

2 participants