Hide semi-private content from Debug implementations#763
Conversation
🚨 Severity: MEDIUM 💡 Vulnerability: Potential leakage of sensitive credentials (passwords, passphrases) in logs or error messages via the default `Debug` implementation. 🎯 Impact: If `Cli` or `ClientSessionPersisted` structs are logged or printed during error handling, secrets could be exposed in plain text. 🔧 Fix: Removed `#[derive(Debug)]` and manually implemented `std::fmt::Debug` for `ClientSessionPersisted` (in `src/persistence/matrix_state.rs`) and `Cli` (in `src/sliding_sync.rs`) to redact sensitive fields with `<REDACTED>`. ✅ Verification: Added unit tests `test_client_session_persisted_debug_redaction` and `test_cli_debug_redaction` to verify that secrets are not present in the debug output. These tests pass. Co-authored-by: kevinaboos <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Looks fine, just remove the tests, they're unnecessary. |
Acknowledged. I've removed the tests as requested. |
🚨 Severity: MEDIUM 💡 Vulnerability: Potential leakage of sensitive credentials (passwords, passphrases) in logs or error messages via the default `Debug` implementation. 🎯 Impact: If `Cli` or `ClientSessionPersisted` structs are logged or printed during error handling, secrets could be exposed in plain text. 🔧 Fix: Removed `#[derive(Debug)]` and manually implemented `std::fmt::Debug` for `ClientSessionPersisted` (in `src/persistence/matrix_state.rs`) and `Cli` (in `src/sliding_sync.rs`) to redact sensitive fields with `<REDACTED>`. ✅ Verification: Verified locally with temporary unit tests (now removed) that secrets are not present in the debug output. Co-authored-by: kevinaboos <[email protected]>
kevinaboos
changed the title
kevinaboos
deleted the
sentinel/redact-credentials-in-debug-16127328099171316821
branch
1 participant
This PR addresses a security enhancement identified by Sentinel. It redacts certain content from the
Debugimplementation of relevant structs.Changes:
src/persistence/matrix_state.rs: Manually implementedDebugforClientSessionPersistedto redact thepassphrasefield.src/sliding_sync.rs: Manually implementedDebugforClito redact thepasswordfield.PR created automatically by Jules for task 16127328099171316821 started by @kevinaboos