Fix Camera.slerp for ortho by cloning projMatrix into uPMatrix when active #8351
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for making the changes! It looks like an autoformatter ran on the file, is it possible to get it to just have the slerp update? |
nakednous
force-pushed
the
fix-camera-slerp-ortho-state
branch
from
3f1961d to
f607b53
Compare
Contributor
Author
|
Formatting reverted; only the minimal slerp fix remains now. Ready for review—thanks! |
davepagurek
approved these changes
Dec 20, 2025
Contributor
davepagurek
left a comment
davepagurek
left a comment
There was a problem hiding this comment.
Thanks so much for your patience on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8295
This PR fixes the crash that occurs when calling
Camera.slerp()between orthographic cameras.The solution updates
uPMatrixusingstates.setValue()—as recommended by @davepagurek—instead of assigning directly tomat4, which avoids the crash while keeping the renderer state consistent.Change:
mat4assignment with astates.setValue('uPMatrix', …)update insideCamera.slerp().