bundle XML and DTD, reduce XML according to usage #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I struggled with providing XML and DTD to this library on my first attempt.
Now, I took the XML and DTD from the DSFinV-K 2.4 archive and include them here as assets. The generator can be used without xml_file and dtd_file arguments and then uses the bundled ones. The XML file is then reduced to only contain the file references that are actually used.
This increases the complexity of this library and this also pulls in lxml as a dependency. I'm fine if you don't want this included in your master, but I thought I'd share it.
This solves my bug report as the sample.py gets working again with this! :)