include select in list of form-tags#91
Conversation
|
Not sure why CI is failing it doesn't seem to be a test but rather some other issue. |
|
Not sure what's up with that. CI seems to be failing on master as well. This project no longer has an active maintainer, and I'm also not sure if the change is correct :/. If you're not sure it's the right thing, maybe best to work with a fork -- but if you are, I'm happy to merge. |
|
@w01fe I'm pretty certain it's correct for newer versions of Om (which are backwards compatible in the sense that the om.now namespaces are still around/intact). I'm using it as fork and it's working well with the When used with an older version it will probably cause trouble. |
|
Ah makes sense. Thanks for the PR and the explanation! Thinking about it a bit, I don't think it makes sense for me to merge since I'm not going to figure out CI issues or cut a release. I think we should just leave this open for whomever (if anyone) takes over maintenance. Sound reasonable? |
|
Sure 👍 |
via omcljs/om@7c1a337
Not sure if this is correct but given that the other
form-tagsare specfied where now alsoselectis defined it makes sense to me :)