You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
FIxes stackoverflow in JIT mode with a trampoline. We should still look for a C lib that could do this stuff or at least do a dirty mutating approach which is more JIT friendly. For now this is at least a simple solution.
I agree the helpers should be private. Trampoline might be the exception as
it is rather useful. My mutating version got over ambitious when I tried
adding some of the TimSort optimizations - it's rather broken at the moment.
Can you make the helper functions (trampoline and the -merge fns) private?
You also mentioned in #361 that you had implemented a version using
arrays, do you still have that or did it not work out?
—
Reply to this email directly or view it on GitHub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIxes stackoverflow in JIT mode with a trampoline. We should still look for a C lib that could do this stuff or at least do a dirty mutating approach which is more JIT friendly. For now this is at least a simple solution.