Skip to content

Conversation

@lidezhu
Copy link
Collaborator

@lidezhu lidezhu commented Dec 22, 2025

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

This pull request focuses on optimizing the performance of ZSTD compression and decompression within the event store. By implementing a strategy to reuse byte buffers for these operations, the changes aim to significantly reduce memory allocation overhead and improve the speed and efficiency of event processing, both when writing and reading compressed data.

Highlights

  • ZSTD Compression Buffer Reuse: The writeEvents function now utilizes a reusable byte buffer for ZSTD compression operations. This change aims to reduce memory allocations and improve performance during event writing by avoiding repeated buffer creation.
  • ZSTD Decompression Buffer Reuse: Similarly, the eventStoreIter has been enhanced to reuse a byte buffer for ZSTD decompression. This optimization minimizes memory allocations during event iteration and reading, contributing to overall efficiency.
  • New Test Case for Buffer Reuse: A new unit test, TestEventStoreCompressionAndIterDecodeBufferReuse, has been added. This test specifically validates the correctness of the buffer reuse logic for both compression and decompression, ensuring data integrity and non-mutation.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 22, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign asddongmen for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 22, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @lidezhu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on optimizing the performance of ZSTD compression and decompression within the event store. By implementing a strategy to reuse byte buffers for these operations, the changes aim to significantly reduce memory allocation overhead and improve the speed and efficiency of event processing, both when writing and reading compressed data.

Highlights

  • ZSTD Compression Buffer Reuse: The writeEvents function now utilizes a reusable byte buffer for ZSTD compression operations. This change aims to reduce memory allocations and improve performance during event writing by avoiding repeated buffer creation.
  • ZSTD Decompression Buffer Reuse: Similarly, the eventStoreIter has been enhanced to reuse a byte buffer for ZSTD decompression. This optimization minimizes memory allocations during event iteration and reading, contributing to overall efficiency.
  • New Test Case for Buffer Reuse: A new unit test, TestEventStoreCompressionAndIterDecodeBufferReuse, has been added. This test specifically validates the correctness of the buffer reuse logic for both compression and decompression, ensuring data integrity and non-mutation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to improve compression and decompression speed by reusing buffers. The changes involve modifying writeEvents to accept a reusable compression buffer and updating eventStoreIter to reuse a decompression buffer. The implementation for buffer reuse in both compression and decompression appears correct and safe. The logic correctly handles buffer resizing and resetting for subsequent uses. The tests have been updated accordingly, and a new test has been added to verify the safety of buffer reuse in the iterator, which is a good addition. Overall, the changes are well-implemented and should achieve the intended performance improvement.

@asddongmen
Copy link
Collaborator

Is there a bench result?

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 23, 2025
@lidezhu
Copy link
Collaborator Author

lidezhu commented Dec 23, 2025

Is there a bench result?

Working on it.

@lidezhu lidezhu force-pushed the ldz/fix-compress1222 branch from bd474fc to cce8ff5 Compare January 4, 2026 01:37
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 4, 2026

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants