-
Notifications
You must be signed in to change notification settings - Fork 31
eventstore: improve compress&decompress speed by reusing buffer #3751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @lidezhu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on optimizing the performance of ZSTD compression and decompression within the event store. By implementing a strategy to reuse byte buffers for these operations, the changes aim to significantly reduce memory allocation overhead and improve the speed and efficiency of event processing, both when writing and reading compressed data. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to improve compression and decompression speed by reusing buffers. The changes involve modifying writeEvents to accept a reusable compression buffer and updating eventStoreIter to reuse a decompression buffer. The implementation for buffer reuse in both compression and decompression appears correct and safe. The logic correctly handles buffer resizing and resetting for subsequent uses. The tests have been updated accordingly, and a new test has been added to verify the safety of buffer reuse in the iterator, which is a good addition. Overall, the changes are well-implemented and should achieve the intended performance improvement.
|
Is there a bench result? |
Working on it. |
bd474fc to
cce8ff5
Compare
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
What problem does this PR solve?
Issue Number: close #xxx
What is changed and how it works?
This pull request focuses on optimizing the performance of ZSTD compression and decompression within the event store. By implementing a strategy to reuse byte buffers for these operations, the changes aim to significantly reduce memory allocation overhead and improve the speed and efficiency of event processing, both when writing and reading compressed data.
Highlights
writeEventsfunction now utilizes a reusable byte buffer for ZSTD compression operations. This change aims to reduce memory allocations and improve performance during event writing by avoiding repeated buffer creation.eventStoreIterhas been enhanced to reuse a byte buffer for ZSTD decompression. This optimization minimizes memory allocations during event iteration and reading, contributing to overall efficiency.TestEventStoreCompressionAndIterDecodeBufferReuse, has been added. This test specifically validates the correctness of the buffer reuse logic for both compression and decompression, ensuring data integrity and non-mutation.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note