Conversation
Updated php version
Updated PHP version matrix
Updated composer.json to support php8.5
Updated Composer Json with PHP 85
Updated the composer for eloquent/liberator
Updated related versions
.github/workflow.yml
Outdated
| @@ -0,0 +1,157 @@ | |||
| name: Unit | |||
There was a problem hiding this comment.
why is this workflow file added/duplicated?
There was a problem hiding this comment.
I deleted newly created Workflow
composer.json
Outdated
| "phpunit/phpunit": "^9.5.25 || ^10.0 || ^11.0", | ||
| "predis/predis": "^1.1.8 || ^2.0", | ||
| "spatie/async": "^1.5" | ||
| "spatie/async": "^1.5 || ^1.8" |
composer.json src/Mutex/DistributedMutex.php
…ce TestAccess for property access
…perty/method access
…support PHP 8.2 and above
Added explicit handling for NaN and infinities in formatTimeout method.
| "ext-pdo_sqlite": "*", | ||
| "ext-redis": "*", | ||
| "ext-sysvsem": "*", | ||
| "eloquent/liberator": "^2.0 || ^3.0", |
There was a problem hiding this comment.
I like this change. Please send it as an extra PR.
Then this PR for PHP 8.5 would be hugely simplified and much more readable.
There was a problem hiding this comment.
can you please help me with a method popsValue this is not defined anywhere. Calling this method is failing the testcases. @mvorisek
There was a problem hiding this comment.
See https://github.com/search?q=repo%3Aeloquent%2Fpops%20popsvalue&type=code , it is part of eloquent/pops package.
There was a problem hiding this comment.
We want to keep PHP 7.4 support and I prefer to drop this testing library because of these exact reasons.
There was a problem hiding this comment.
Thanks for the review and now I understand "why". I will revert those changes back. I need to figure out how can we write test cases and improve the code coverage without that library. I am thinking of using Mockery library and see how can we achieve the same functionality. This is now an interesting challenge @mvorisek 😁
…e parameter consistency
…otations, and update TestAccess invocation for consistency
…properties and improve strategy assignment consistency
…ions for improved clarity
…emove redundant annotations
… improved type clarity
| * @param \Closure(float): Mutex $mutexFactory | ||
| * @param \Closure(): void $setUp | ||
| * | ||
| * @dataProvider provideHighContentionCases |
There was a problem hiding this comment.
You need to keep these annotations for PHP 7.4...
…ndant annotations, and clean up imports
…e` for compatibility across PHPUnit versions and clean up imports
…estAccess` usage across multiple test cases
…ie/async patch 8.0+ compatibility
…ie/async patch 8.0+ compatibility
…ie/async patch 8.0+ compatibility
2 participants
fix #81