Fix collisions when moving from one-way to slopes#92
Open
matt-flaig wants to merge 1 commit intophoboslab:masterfrom
Open
Fix collisions when moving from one-way to slopes#92matt-flaig wants to merge 1 commit intophoboslab:masterfrom
matt-flaig wants to merge 1 commit intophoboslab:masterfrom
Conversation
When moving from one-way tiles to upward slopes, entities would get stuck at the edge of the slope and require upwards momentum to be able to continue moving forwards.
|
Glad to see someone is still watching impact.js . I think you are an expert in impact.js area . Do you tell me something about this #99 ? Thanks. |
|
I merged your solution and added some slopes in the test.js map (box2d physics demo) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When moving from one-way tiles to upward slopes, entities would get stuck at the edge of the slope and require upwards momentum to be able to continue moving forwards.
Here's a sample entity trying to move up a slope from a one-way tile, previously:

Here's the entity freely moving up the slope with this fix:
