Make landscape banners full-width#405
Merged
phoboslab merged 1 commit intophoboslab:masterfrom Jul 9, 2014
Merged
Conversation
Set currentContentSizeIdentifier in landscape mode per https://developer.apple.com/library/ios/documentation/userexperience/Conceptual/iAd_Guide/BannerAdvertisements/BannerAdvertisements.html
Owner
|
Thanks! |
phoboslab
added a commit
that referenced
this pull request
Jul 9, 2014
Make landscape banners full-width
Contributor
|
@phoboslab , I point this issue at #351 , I don't know why you are not interested in my PR always. and #400 is a critical bug , I hope it could interest you. |
Owner
|
@finscn: you're opening a lot of issues, intermix feature additions with bugfixes and I guess there's a big language barrier as well. It's just hard to keep track. Sorry :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set currentContentSizeIdentifier in landscape mode per
https://developer.apple.com/library/ios/documentation/userexperience/Conceptual/iAd_Guide/BannerAdvertisements/BannerAdvertisements.html