fix the size of iAd banner in iPad under landscape#349
Closed
finscn wants to merge 2 commits intophoboslab:masterfrom
Closed
fix the size of iAd banner in iPad under landscape#349finscn wants to merge 2 commits intophoboslab:masterfrom
finscn wants to merge 2 commits intophoboslab:masterfrom
Conversation
added 2 commits
March 7, 2014 14:14
there is a bug: in landscape iPad (test on iOS 6.13), the iAd banner's width is always 768px . and in new iOS , the apple suggest to use sizeThatFits , so I pull this request.
Contributor
Author
|
ignore this pull request. See #351 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is a bug: in landscape iPad (test on iOS 6.13), the iAd banner's width is always 768px .
and in new iOS , the apple suggest to use sizeThatFits , so I pull this request.