refactor: change step handler input to use asymmetric pattern for better type safety #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Author
|
View your CI Pipeline Execution ↗ for commit 85fb718
☁️ Nx Cloud last updated this comment at |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
jumski
force-pushed
the
12-23-feat_asymmetric_handler_signatures_for_step_array_methods
branch
from
86ca44b to
b47e937
Compare
This was referenced Dec 23, 2025
jumski
force-pushed
the
12-23-feat_asymmetric_handler_signatures_for_step_array_methods
branch
from
b47e937 to
f182e2d
Compare
jumski
force-pushed
the
12-23-add_flowinput_to_worker_context_from_task_record
branch
from
a13db51 to
ff6500d
Compare
Contributor
Author
jumski
changed the base branch from
12-23-add_flowinput_to_worker_context_from_task_record
to
graphite-base/556
- Root steps receive flowInput directly (no run key wrapper) - Dependent steps receive deps object only, flowInput via context - Add flowInput to FlowContext type - Update all type tests and example flows - Update edge-worker and client packages for compatibility
jumski
force-pushed
the
12-23-feat_asymmetric_handler_signatures_for_step_array_methods
branch
from
f182e2d to
85fb718
Compare
Contributor
🚀 Production Deployment: Website✅ Successfully deployed to production! 🔗 Production URL: https://pgflow.dev 📝 Details:
Deployed at: 2025-12-30T12:40:25+01:00 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asymmetric Step Input Pattern for Improved Type Safety and Composition
This PR introduces a significant improvement to the step input pattern across the PgFlow DSL:
runwrapper)context.flowInput)This change enables better functional composition where subflows can receive typed inputs without the
runwrapper that previously blocked type matching. The asymmetric input pattern makes the API more intuitive while maintaining full type safety.Key Changes:
StepInpututility type to implement the asymmetric patternflowInputinstead ofinput.runflowInputto theFlowContextinterface for dependent stepsThis change is backward compatible at runtime but will require updating handler parameter names in client code. The improved type safety and composability are worth the minor migration effort.