[FEATURE]: Adds support for log type y-axis (as well as linear) for TimeSeriesChart #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olandr
force-pushed
the
feat/logarithmic-support-3434
branch
2 times, most recently
from
d839dd5 to
dcb9f97
Compare
Nexucis
requested review from
a team and
jgbernalp
and removed request for
a team
Contributor
|
@olandr there are some lint errors, can you check when you have some time? |
olandr
force-pushed
the
feat/logarithmic-support-3434
branch
from
dcb9f97 to
334ffbd
Compare
olandr
requested review from
a team,
AntoineThebaud and
Nexucis
as code owners
…imeSeriesChart - adds possibility for choosing the "ECharts yaxis type:log" field instead of just 'value'. - adds options for choosing log-base (2, 10) - adds cue and updates go-sdk with logbase --------- Signed-off-by: Simon Olander <[email protected]>
olandr
force-pushed
the
feat/logarithmic-support-3434
branch
from
334ffbd to
9871835
Compare
Contributor
Author
|
The failing test is a bit confusing to me, I am not very certain on what the test is actually testing (or how it really is connected to my changes?). I can also not replicate the failing test locally (all PASS). Any suggestions what should be done here? |
Contributor
|
it seems it was a flaky test. |
jgbernalp
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements log-based Yaxis for the TimeSeriesChart.
It does so by exposing the yaxis.logBase field of
YAXisComponentOptionto the user. NOTE: To make this possible one key feature had to be implemented in the UI components of Perses for the calculation of nearby-series/hover see perses/shared#11.Screenshots
None
log2
log10
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes