Draft
Conversation
Contributor
Author
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
Example of PR titles that include pivotal stories:
Generated by 🚫 dangerJS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces no changes but a failing test. It serves to demonstrate the existence of a bug spotted in pagopa/io-app#2717. It adds 2 test:
<statusCode, responseDecoder>mapResults
While the first test passes, the second fails. I understand this happens because the generated
requestTypesmodules ships a functionisDecoderwhich is wrong in determining if the value passed is a decoder or a map of decoders; by failing this, it erroneously treat a single decoder as a map of decoders, hence the bug.Here the implementation.
Proposed solution
provide a working
isDecoderimplamentationMitigation
Just use an explicit decoder map.
Please note that, given a
aCustomDecoderdecoder and a request withstatusas a default success status code, the following two instructions build the very same response decoder:How Has This Been Tested?
E2E test suites