Centralize "don't animate" logic for side modals#3007
Merged
david-crespo merged 1 commit intomainfrom Jan 9, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
force-pushed
the
centralize-modal-animate-logic
branch
from
490f95f to
ab61553
Compare
charliepark
approved these changes
Jan 9, 2026
Contributor
charliepark
left a comment
charliepark
left a comment
There was a problem hiding this comment.
Tried it with reduce motion on my Mac and all looks good!
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 5, 2026
oxidecomputer/console@a5fc417...948c1d3 * [948c1d33](oxidecomputer/console@948c1d33) oxidecomputer/console#3021 * [cd0a0db6](oxidecomputer/console@cd0a0db6) oxidecomputer/console#3027 * [002af426](oxidecomputer/console@002af426) oxidecomputer/console#3005 * [61464d9f](oxidecomputer/console@61464d9f) oxidecomputer/console#3024 * [7ca66ea6](oxidecomputer/console@7ca66ea6) oxidecomputer/console#3018 * [53441694](oxidecomputer/console@53441694) oxidecomputer/console#3023 * [ed139b14](oxidecomputer/console@ed139b14) oxidecomputer/console#2974 * [62e0e4d6](oxidecomputer/console@62e0e4d6) oxidecomputer/console#3020 * [c916d668](oxidecomputer/console@c916d668) oxidecomputer/console#3002 * [b9344ef0](oxidecomputer/console@b9344ef0) oxidecomputer/console#3007 * [111646f4](oxidecomputer/console@111646f4) oxidecomputer/console#3003
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 6, 2026
oxidecomputer/console@a5fc417...948c1d3 * [948c1d33](oxidecomputer/console@948c1d33) oxidecomputer/console#3021 * [cd0a0db6](oxidecomputer/console@cd0a0db6) oxidecomputer/console#3027 * [002af426](oxidecomputer/console@002af426) oxidecomputer/console#3005 * [61464d9f](oxidecomputer/console@61464d9f) oxidecomputer/console#3024 * [7ca66ea6](oxidecomputer/console@7ca66ea6) oxidecomputer/console#3018 * [53441694](oxidecomputer/console@53441694) oxidecomputer/console#3023 * [ed139b14](oxidecomputer/console@ed139b14) oxidecomputer/console#2974 * [62e0e4d6](oxidecomputer/console@62e0e4d6) oxidecomputer/console#3020 * [c916d668](oxidecomputer/console@c916d668) oxidecomputer/console#3002 * [b9344ef0](oxidecomputer/console@b9344ef0) oxidecomputer/console#3007 * [111646f4](oxidecomputer/console@111646f4) oxidecomputer/console#3003
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very minor, just had it on my todo list and Opus knocked it out. #2992 added a bunch of
useNavigationTypecalls that I realized should be centralized in the side modal component itself