Eliminate dependency on Swing and call to invokeLater#345
Open
JaroslavTulach wants to merge 2 commits intooracle:masterfrom
Open
Eliminate dependency on Swing and call to invokeLater#345JaroslavTulach wants to merge 2 commits intooracle:masterfrom
JaroslavTulach wants to merge 2 commits intooracle:masterfrom
Conversation
lbownik
reviewed
May 19, 2023
| } | ||
|
|
||
| synchronized static void notifyUpdates(Handle h, int type) { | ||
| private synchronized static void notifyUpdates(Handle h, Type type) { |
There was a problem hiding this comment.
how bout ?
private synchronized static void notifyUpdates(Handle h, BiConsumer<Listener, Handle> c) {
for (Listener onChange : listeners) {
c.accept(onChange, h);
}
}
and then call it like
@Override
public void close() {
notifyUpdates(this, 2);
notifyUpdates(this, Listener::finished);
}
0x6675636b796f75676974687562
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a support for reporting progress of long running operations via the
HeapProgressclass. However this class directly calls into AWT which would better be avoided if the librrary is supposed to be used in a headless mode.This PR keeps the compatibility with existing
HeapProgressbehavior, yet it avoid the AWT interactions until somebody accessHeapProgress.getProgress()model.