Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Dec 12, 2025

I meant for this to be part of #2382

Rather than litter the root directory with kind configs, add them to a subdirectory.
Also rename the experimental one to indicate it's for 2 nodes.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Rather than litter the root directory with kind configs, add them to
a subdirectory.
Also rename the experimental one to indicate it's for 2 nodes.

Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort requested a review from a team as a code owner December 12, 2025 16:46
@openshift-ci openshift-ci bot requested review from OchiengEd and oceanc80 December 12, 2025 16:46
@netlify
Copy link

netlify bot commented Dec 12, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 955fc61
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/693c46d4ec9fe000085830bd
😎 Deploy Preview https://deploy-preview-2384--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2025
@pedjak
Copy link
Contributor

pedjak commented Dec 12, 2025

/approve

@openshift-ci
Copy link

openshift-ci bot commented Dec 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 87b2a72 into operator-framework:main Dec 12, 2025
24 checks passed
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.05%. Comparing base (841cbde) to head (955fc61).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2384      +/-   ##
==========================================
+ Coverage   70.50%   73.05%   +2.55%     
==========================================
  Files         100      100              
  Lines        7641     7641              
==========================================
+ Hits         5387     5582     +195     
+ Misses       1847     1623     -224     
- Partials      407      436      +29     
Flag Coverage Δ
e2e 44.73% <ø> (?)
experimental-e2e 49.37% <ø> (+0.02%) ⬆️
unit 57.11% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort tmshort deleted the move-kind-configs branch December 12, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants