-
Notifications
You must be signed in to change notification settings - Fork 3.8k
pbr: update to 1.2.1-45 #28202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pbr: update to 1.2.1-45 #28202
Conversation
|
Could you also fix this circular dependency issue while you're at it? |
net/pbr/Makefile
Outdated
| $(call Package/pbr/default/description) | ||
| This version supports OpenWrt (23.05 and newer) with firewall4/nft. | ||
| This service enables policy-based routing for WAN interfaces and various VPN tunnels. | ||
| This version supports OpenWrt (23.05 and newer) with firewall4/nft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this supports 23.05 and newer, shouldn't be there provides for vpn-policy-routing and vpnbypass?
To fix https://forum.turris.cz/t/problem-po-automaticke-aktualizaci-routeru-turris-omnia-wi-fi-6/22238 (sorry only in Czech), basically issue is that users have installed vpn-policy-routing and while going from ancient OpenWrt version to OpenWrt 24.10, the package is gone as it was removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PROVIDES for vpnbypass and vpn-policy-routing was removed from the Makefile in August 2024, by then it's been two years since pbr replaced vpnbypass and vpn-policy-routing in OpenWrt packages repos (starting with 22.03 branch).
While a lot of effort has been made to ensure transition from the vpn-policy-routing to iptables-capable version of pbr back in the day, for the current version of pbr, which relies not only on nft, but fw4 nft files, there's no upgrade path from vpn-policy-routing to pbr. The README for pbr 1.2.0 (most recent in the stable branch): https://docs.openwrt.melmac.ca/pbr/#version-120 clearly states there's no upgrade path.
If user were to search for the vpn-policy-routing README, it mentions the pbr as a replacement package: https://docs.openwrt.melmac.ca/vpn-policy-routing/
Without pbr flavours it's easier to reinstate PROVIDES for the obsolete packages, I'm just not sure if it's worth the electrons to even mention packages which have been obsolete for almost 4 years.
Makefile: * remove traces of variants and simplify * more sensible DEPENDS section (thanks @BKPepe) Init-script: * introduce prefixlength option to speed up tables operations (thanks @egc112) Signed-off-by: Stan Grishin <[email protected]>
|
@BKPepe I seem to have overcome the IDE and now the Makefile has proper spaces/tabs, based on your comments and the Makefile for bind from this repo. |
Maintainer: me
Compile tested: x86_64, Dell EMC Edge 620, OpenWrt 24.10.4
Run tested: x86_64, Dell EMC Edge 620, OpenWrt 24.10.4
Description:
Makefile:
Init-script: