Add comprehensive unit tests for migration functions#2309
Open
Achieve3318 wants to merge 1 commit intoopentensor:mainfrom
Open
Add comprehensive unit tests for migration functions#2309Achieve3318 wants to merge 1 commit intoopentensor:mainfrom
Achieve3318 wants to merge 1 commit intoopentensor:mainfrom
Conversation
- Add 6 tests for migrate_delete_subnet_3 (subnet deletion, storage cleanup) - Add 7 tests for migrate_to_v1_separate_emission (format translation) - Add 4 tests for migrate_to_v2_fixed_total_stake (version gating, docs) - Add 7 tests for migrate_total_issuance (calculation, error handling) Resolves all TODO comments requesting unit tests and error handling in migration files. Total: 733 lines, 24 new tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves all TODO comments requesting unit tests and error handling in migration files. Total: 733 lines, 24 new tests.
Description
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.