Skip to content

Conversation

@barbacbd
Copy link

Added GCP as a platform that supports DualStack on Day-0
Added GCP as a platform that does not support conversion to DualStack on Day-2
Added tests for GCP

** GCP is behind a featuregate. Ensure that these featuregates are enablede before dual stack support is extended to GCP.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 28, 2026

@barbacbd: This pull request references CORS-4332 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Added GCP as a platform that supports DualStack on Day-0
Added GCP as a platform that does not support conversion to DualStack on Day-2
Added tests for GCP

** GCP is behind a featuregate. Ensure that these featuregates are enablede before dual stack support is extended to GCP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@barbacbd
Copy link
Author

/hold

@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

Walkthrough

Adds GCP dual-stack gating and related test updates: render logic now recognizes GCP as a supported dual-stack platform when the GCP dual-stack feature gate is enabled; tests updated to drive dual-stack behavior via feature gates and adjusted platform setups/statuses.

Changes

Cohort / File(s) Summary
Platform support logic
pkg/network/render.go
Extend isSupportedDualStackPlatform to include configv1.GCPPlatformType gated by apifeatures.FeatureGateGCPDualStackInstall; update comment to mention GCP alongside AWS and Azure.
Cluster config tests
pkg/network/cluster_config_test.go
Update tests to drive dual-stack allowance via feature gates: add FeatureGateGCPDualStackInstall to dual-stack feature sets; adjust platform-type setups and status initializations so dual-stack is allowed only when the feature gate is present and disallowed when missing.
Render tests
pkg/network/render_test.go
Add FeatureGateGCPDualStackInstall to default dual-stack feature gates; set infra.PlatformType to GCPPlatformType in TestAllowMigrationOnlyForSupportedTypes to validate GCP path.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2026
@openshift-ci openshift-ci bot requested review from jcaamano and ricky-rav January 28, 2026 15:46
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: barbacbd
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Added GCP as a platform that supports DualStack on Day-0
Added GCP as a platform that does not support conversion to DualStack on Day-2
Added tests for GCP

** GCP is behind a featuregate. Ensure that these featuregates are enablede before
dual stack support is extended to GCP.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2026

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.22-upgrade-from-stable-4.21-e2e-azure-ovn-upgrade e7e4777 link false /test 4.22-upgrade-from-stable-4.21-e2e-azure-ovn-upgrade
ci/prow/hypershift-e2e-aks e7e4777 link true /test hypershift-e2e-aks
ci/prow/e2e-aws-ovn-upgrade e7e4777 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-upgrade-ipsec e7e4777 link true /test e2e-aws-ovn-upgrade-ipsec
ci/prow/lint e7e4777 link true /test lint
ci/prow/e2e-aws-ovn-serial-1of2 e7e4777 link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec e7e4777 link true /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade e7e4777 link false /test 4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade
ci/prow/e2e-ovn-ipsec-step-registry e7e4777 link true /test e2e-ovn-ipsec-step-registry
ci/prow/security e7e4777 link false /test security
ci/prow/e2e-aws-ovn-hypershift-conformance e7e4777 link true /test e2e-aws-ovn-hypershift-conformance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants