Skip to content

Conversation

@nizarbenalla
Copy link
Member

@nizarbenalla nizarbenalla commented Dec 21, 2025

The test no longer needs to be problem listed now that the symbol information has caught up and is up to date.
This PR has a dependency on #28944, I want them integrate them in order.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8372801: tools/sincechecker/modules/java.base/JavaBaseCheckSince.java fails with JDK 27 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28945/head:pull/28945
$ git checkout pull/28945

Update a local copy of the PR:
$ git checkout pull/28945
$ git pull https://git.openjdk.org/jdk.git pull/28945/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28945

View PR using the GUI difftool:
$ git pr show -t 28945

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28945.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 21, 2025

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 21, 2025

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372801: tools/sincechecker/modules/java.base/JavaBaseCheckSince.java fails with JDK 27

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 21, 2025

@nizarbenalla The following labels will be automatically applied to this pull request:

  • compiler
  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@nizarbenalla
Copy link
Member Author

/label add javadoc
/label add core-libs

@nizarbenalla
Copy link
Member Author

/label remove jmx
/label remove compiler
/label remove serviceability

@openjdk
Copy link

openjdk bot commented Dec 21, 2025

@nizarbenalla
The javadoc label was successfully added.

@openjdk
Copy link

openjdk bot commented Dec 21, 2025

@nizarbenalla
The core-libs label was successfully added.

@openjdk
Copy link

openjdk bot commented Dec 21, 2025

@nizarbenalla
The jmx label was successfully removed.

@openjdk
Copy link

openjdk bot commented Dec 21, 2025

@nizarbenalla
The compiler label was successfully removed.

@openjdk
Copy link

openjdk bot commented Dec 21, 2025

@nizarbenalla
The serviceability label was successfully removed.

@nizarbenalla nizarbenalla changed the base branch from master to pr/28944 December 21, 2025 14:48
@nizarbenalla nizarbenalla marked this pull request as ready for review December 21, 2025 14:48
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 21, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 21, 2025

Webrevs

@nizarbenalla
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 24, 2025

@nizarbenalla This pull request has not yet been marked as ready for integration.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/28944 to master December 24, 2025 14:44
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8372801
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 24, 2025
@nizarbenalla
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 24, 2025

Going to push as commit 98b7792a072380978b09fda4ec194f333d2ce7e3.
Since your change was applied there have been 25 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 24, 2025
@openjdk openjdk bot closed this Dec 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 24, 2025
@openjdk
Copy link

openjdk bot commented Dec 24, 2025

@nizarbenalla Pushed as commit 98b7792.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@nizarbenalla nizarbenalla deleted the 8372801 branch December 24, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants