-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8372801: tools/sincechecker/modules/java.base/JavaBaseCheckSince.java fails with JDK 27 #28945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The macOS/AArch64 build 29 was taken from https://jdk.java.net/26/
|
👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into |
|
@nizarbenalla This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 25 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@nizarbenalla The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
|
/label add javadoc |
|
/label remove jmx |
|
@nizarbenalla |
|
@nizarbenalla |
|
@nizarbenalla |
|
@nizarbenalla |
|
@nizarbenalla |
Webrevs
|
|
/integrate |
|
@nizarbenalla This pull request has not yet been marked as ready for integration. |
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8372801
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
/integrate |
|
Going to push as commit 98b7792a072380978b09fda4ec194f333d2ce7e3.
Your commit was automatically rebased without conflicts. |
|
@nizarbenalla Pushed as commit 98b7792. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The test no longer needs to be problem listed now that the symbol information has caught up and is up to date.
This PR has a dependency on #28944, I want them integrate them in order.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28945/head:pull/28945$ git checkout pull/28945Update a local copy of the PR:
$ git checkout pull/28945$ git pull https://git.openjdk.org/jdk.git pull/28945/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28945View PR using the GUI difftool:
$ git pr show -t 28945Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28945.diff
Using Webrev
Link to Webrev Comment