Update UI base images for Translation and VisualQnA #2398
Conversation
Signed-off-by: ZePan110 <[email protected]>
ZePan110
requested review from
Spycsh,
WenjiaoYue,
lvliang-intel and
yao531441
as code owners
|
ℹ️ INFO |
There was a problem hiding this comment.
Pull request overview
This PR updates the Node.js base Docker images for the Translation and VisualQnA UI services from specific Node 20.x versions to Node 22.
Changes:
- Updated VisualQnA UI Docker base image from node:20.11.1 to node:22
- Updated Translation UI Docker base image from node:20.19.0 to node:22
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| VisualQnA/ui/docker/Dockerfile | Updates base image from Node 20.11.1 to Node 22 |
| Translation/ui/docker/Dockerfile | Updates base image from Node 20.19.0 to Node 22 while maintaining chokidar compatibility note |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # Use node 20.19.0 as the base image (required for [email protected] compatibility) | ||
| FROM node:20.19.0 | ||
| # Use node 22 as the base image (required for [email protected] compatibility) |
There was a problem hiding this comment.
The comment mentions [email protected] compatibility requirements, but this justification was originally specific to Node 20.19.0. Since the image is now being updated to Node 22, verify if this comment accurately reflects the compatibility requirements for Node 22 with [email protected], or update the comment to reflect the actual reason for using Node 22.
| # Use node 22 as the base image (required for [email protected] compatibility) | |
| # Use Node 22 as the base image (current LTS / stable Node.js version) |
for more information, see https://pre-commit.ci
pre-commit-ci
bot
requested review from
chensuyue,
ftian1,
lkk12014402,
minmin-intel and
rbrugaro
as code owners
|
VisualQnA is known issue #2399 |
|
ℹ️ INFO |
Description
Update UI base images for Translation and VisualQnA
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.