Replace COA.call with COA.callWithSigAndArgs for reduced computation cost#77
Draft
Replace COA.call with COA.callWithSigAndArgs for reduced computation cost#77
COA.call with COA.callWithSigAndArgs for reduced computation cost#77Conversation
ae6fa70 to
12290b2
Compare
12290b2 to
85dc5f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: onflow/flow-go#8401
Closes: #76
Description
Previously, to perform contract calls using a COA, it was necessary to produce the
callDataon Cadence side:To be able to ABI-decode the returned data from the COA call, another step was needed:
After doing some profiling on Cadence transactions, the computation cost of ABI encoding/decoding, amounted to about 15%-20% of the total computation, which is not trivial.
To optimize this case, we have a new wrapper function,
callWithSigAndArgs, which does all this more efficiently:We do the same for
dryCall, by replacing it withdryCallWithSigAndArgs.NOTE: CI is failing because we still need to deploy the
EVMsystem contract on testnet/mainnet, for these new functions to be available.