Add Pool.getPositionCount() and get_position_count script#270
Draft
vishalchangrani wants to merge 1 commit intov0from
Draft
Add Pool.getPositionCount() and get_position_count script#270vishalchangrani wants to merge 1 commit intov0from
vishalchangrani wants to merge 1 commit intov0from
Conversation
Expose the total number of active positions in the FlowALPv0 Pool via a new public view getter on the Pool resource, and a corresponding Cadence script for off-chain querying. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getPositionCount() : Intas a publicviewfunction on thePoolresource inFlowALPv0.cdc, returningself.positions.lengthcadence/scripts/flow-alp/get_position_count.cdc— a Cadence script that resolves the Pool from the protocol account and returns the countcadence/tests/get_position_count_test.cdccovering: zero count on a fresh pool, and correct increment as positions are openedContext
This is needed for the FCM Observer to be able to query the total number of active positions in the Pool without requiring any off-chain event indexing or privileged access.
Test plan
test_position_count_is_zero_initially— asserts count is 0 before any positions are openedtest_position_count_reflects_open_positions— opens 2 positions across 2 users, asserts count increments correctly to 1 then 2🤖 Generated with Claude Code