Skip to content

fix: use resolvedVersion on package page to display data correctly#1969

Open
alex-key wants to merge 2 commits intonpmx-dev:mainfrom
alex-key:fix/range-version-empty-readme
Open

fix: use resolvedVersion on package page to display data correctly#1969
alex-key wants to merge 2 commits intonpmx-dev:mainfrom
alex-key:fix/range-version-empty-readme

Conversation

@alex-key
Copy link
Contributor

@alex-key alex-key commented Mar 6, 2026

🔗 Linked issue

Resolves #1967

🧭 Context

Requested version could be semver range not real existing package version

📚 Description

Mainly use resolvedVersion for any api calls and everywhere by default. Use requestedVersion only to display resolution widget, for url or meta

@vercel
Copy link

vercel bot commented Mar 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Error Error Mar 6, 2026 10:38pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 6, 2026 10:38pm
npmx-lunaria Ignored Ignored Mar 6, 2026 10:38pm

Request Review

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/pages/package/[[org]]/[name].vue 0.00% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c2141f10-34ba-49b0-ac62-14ab750e0c5d

📥 Commits

Reviewing files that changed from the base of the PR and between f458531 and 3907a78.

📒 Files selected for processing (1)
  • server/api/atproto/bluesky-author-profiles.get.ts

📝 Walkthrough

Walkthrough

The package page now resolves a requested semver range to a concrete resolvedVersion early in setup and uses resolvedVersion.value for all subsequent read operations (readme, readme markdown, install size, skills and other reads). Duplicate resolvedVersion fetches were removed. Error handling and 404 signalling now use resolvedStatus. The install flow and navigation links were updated to display and pass the resolved version instead of the original requested range.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining that resolvedVersion should be used for API calls and data display instead of requestedVersion.
Linked Issues check ✅ Passed The changes directly address issue #1967 by using resolvedVersion for API calls (readme, install size, skills, etc.) instead of requestedVersion, ensuring version-specific content reflects the actual resolved concrete version.
Out of Scope Changes check ✅ Passed The changes are appropriately scoped: modifications to use resolvedVersion in the package page component and the MD5 hash caching improvement in the Bluesky API are both related to ensuring correct version handling.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alex-key
Copy link
Contributor Author

alex-key commented Mar 6, 2026

Vercel deployment is failing because of

Error:  Failed to load JWKs. May not be set

What could be the cause? Could it be that OAUTH_JWK_ONE somehow not defined on Netlify side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package page with version resolved from semver range displayed incorrectly

1 participant