Skip to content

fix: improve sponsors layout on the about page for mobile users#1890

Merged
ghostdevv merged 4 commits intonpmx-dev:mainfrom
iiio2:chore/improve-sponsors-layout-on-mobile
Mar 4, 2026
Merged

fix: improve sponsors layout on the about page for mobile users#1890
ghostdevv merged 4 commits intonpmx-dev:mainfrom
iiio2:chore/improve-sponsors-layout-on-mobile

Conversation

@iiio2
Copy link
Contributor

@iiio2 iiio2 commented Mar 3, 2026

Before:

wrong

After:

correct

@vercel
Copy link

vercel bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 4, 2026 7:18pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 4, 2026 7:18pm
npmx-lunaria Ignored Ignored Mar 4, 2026 7:18pm

Request Review

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9529723b-e71c-425f-be5a-c63c4bcf4dbc

📥 Commits

Reviewing files that changed from the base of the PR and between 50596d5 and 2ed88bc.

📒 Files selected for processing (1)
  • app/pages/about.vue

📝 Walkthrough

Walkthrough

The change updates the Sponsors section in app/pages/about.vue by replacing a vertical flex-column layout with a two-column grid on small screens (grid grid-cols-2) while retaining a flex-row layout on medium and larger viewports (md:flex md:flex-row md:items-center). No data sources, logic, or exported/public signatures were modified; only the responsive presentation and arrangement of the AboutLogoList were changed.

Possibly related PRs

Suggested labels

front

Suggested reviewers

  • 43081j
  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description directly relates to the changeset, showing visual before/after comparisons of the sponsors layout modifications from vertical to grid arrangement.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@iiio2
Copy link
Contributor Author

iiio2 commented Mar 4, 2026

@43081j , I've done it.

@iiio2 iiio2 requested a review from 43081j March 4, 2026 16:50
@43081j
Copy link
Contributor

43081j commented Mar 4, 2026

im not sure whats going on with CI

it still thinks there are two gap-4's 🤔

@ghostdevv
Copy link
Contributor

im not sure whats going on with CI

it still thinks there are two gap-4's 🤔

seems to be because the underlying component has gap-4 - fixed in 2ed88bc

@ghostdevv ghostdevv enabled auto-merge March 4, 2026 19:16
@ghostdevv ghostdevv disabled auto-merge March 4, 2026 19:16
@ghostdevv ghostdevv changed the title chore: improve sponsors layout on mobile fix: about page sponsors layout on mobile Mar 4, 2026
@ghostdevv ghostdevv changed the title fix: about page sponsors layout on mobile fix: improve sponsors layout on the about page for mobile users Mar 4, 2026
@ghostdevv ghostdevv enabled auto-merge March 4, 2026 19:18
@ghostdevv ghostdevv added this pull request to the merge queue Mar 4, 2026
Merged via the queue into npmx-dev:main with commit af71229 Mar 4, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants