Skip to content

Conversation

@tataruty
Copy link
Contributor

@tataruty tataruty commented Dec 3, 2025

Proposed changes

Problem: Need to track ProxySettingsPolicy telemetry
Solution:
add a product telemetry field to track the usage of ProxySettingsPolicy
update product telemetry doc with this new tracking information

Testing: unit tests.

TODO testing

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #4304

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

NONE

@tataruty tataruty requested a review from a team as a code owner December 3, 2025 19:03
@github-actions github-actions bot added enhancement New feature or request tests Pull requests that update tests labels Dec 3, 2025
Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI: merge this PR after you have tested the feature on prod data

@tataruty tataruty force-pushed the enh/proxy_settings_policy_telemetry branch from fa97550 to 73c60fb Compare December 8, 2025 15:45
@tataruty tataruty requested review from bjee19 and salonichf5 December 9, 2025 10:58
@github-project-automation github-project-automation bot moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Dec 9, 2025
@tataruty tataruty force-pushed the enh/proxy_settings_policy_telemetry branch from 59d431c to 73c60fb Compare December 11, 2025 10:23
@tataruty tataruty requested a review from bjee19 December 11, 2025 10:32
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, keep us updated on the manual testing to the upstream before merging, nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request tests Pull requests that update tests

Projects

Status: 🏗 In Progress

Development

Successfully merging this pull request may close these issues.

4 participants