-
Notifications
You must be signed in to change notification settings - Fork 152
Add telemetry for ProxySettingsPolicy #4388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/proxy-settings-policy
Are you sure you want to change the base?
Add telemetry for ProxySettingsPolicy #4388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI: merge this PR after you have tested the feature on prod data
fa97550 to
73c60fb
Compare
59d431c to
73c60fb
Compare
bjee19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, keep us updated on the manual testing to the upstream before merging, nice work!
Proposed changes
Problem: Need to track ProxySettingsPolicy telemetry
Solution:
add a product telemetry field to track the usage of ProxySettingsPolicy
update product telemetry doc with this new tracking information
Testing: unit tests.
TODO testing
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #4304
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes