fix: handle null mime type in preview generation#58803
Open
boris324 wants to merge 1 commit intonextcloud:masterfrom
Open
fix: handle null mime type in preview generation#58803boris324 wants to merge 1 commit intonextcloud:masterfrom
boris324 wants to merge 1 commit intonextcloud:masterfrom
Conversation
boris324
requested review from
artonge,
nfebe,
salmart-dev and
sorbaugh
and removed request for
a team
Contributor
|
Still needed after #58793? |
Member
|
Why 2 PR? Is this some AI bot? Just asking 😝 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58784
When generating previews for images with unusual dimensions (e.g. 18x4312 GIF),
IImage::dataMimeType()can return null. This null value gets passed toPreview::setMimeType(string), causing a TypeError that crashes the entireocc preview:generate-allbatch.This adds null checks for the MIME type returned by
dataMimeType()in both preview generation paths:generateProviderPreview(): skip to the next provider with a warning loggeneratePreview(): throwNotFoundExceptionso the file is skipped gracefullyBoth are already handled by callers, so one bad file no longer terminates the batch.