feat(routing): add files_sharing_raw to rootUrlApps#58648
Merged
Conversation
- Registers the files_sharing_raw app as a root-URL app so that its routes are served under /raw/{token} and /rss instead of the default /apps/files_sharing_raw/... prefix.
This is required for the files_sharing_raw app to generate correct canonical raw URLs via PublicUrlBuilder.
Signed-off-by: ernolf <[email protected]>
ernolf
requested review from
ArtificialOwl,
come-nc,
icewind1991 and
leftybournes
and removed request for
a team
CarlSchwan
approved these changes
Mar 2, 2026
Member
|
code and usecase make sense to me . But cc @AndyScherzinger to be sure this is something we want to allow product wise |
Member
|
@CarlSchwan yes, fine by me and also something that got requested in the past already. So it makes sense and there is actual demand 👍 |
Contributor
Author
|
Is backport to 32 and 33 fine? |
Member
|
/backport to stable33 |
Member
|
/backport to stable32 |
Contributor
|
@AndyScherzinger can this be merged? |
Member
|
@szaimen - see #58648 (comment) - yes 👍 |
Member
|
I just didn't sent an approval, since I don't do a technical review, hence an actual 2nd review would be appreciated. My approval is feature/behavior-wise not code-wise. |
szaimen
added
4. to release
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
files_sharing_rawin the\$rootUrlAppsarray inRouteParser.php/raw/{token},/rss) instead of the/apps/files_sharing_raw/...fallbackTODO
Checklist
3. to review, feature component)stable32)AI (if applicable)