Skip to content

Conversation

@julien-nc
Copy link
Member

"Simple" way to reproduce

Try to schedule a task with invalid output so the scheduling request fails. I did this by running an old translation task again (with "Try again") after having changed the provider so the language enum values had changed.

Issue

When the scheduling request fails

  1. If the assistant was opened from the top menu, the modal is closed
  2. If the assistant was opened from a notification, we stay in a weird loading state but still having the old task loaded (so canceling actually deletes the old task...)
  3. On the assistant standalone page, same as 2.
  4. In every case, we get an ugly toast message with [Object, Object] because we try to display the message from the response with accessing the wrong attributes

Fix

When the scheduling request fails

  • Do not close the assistant modal (case 1.)
  • Put the assistant back in its previous state: nothing is loading, we stay on the current task
  • Print the error in the browser log

Additional change: Catch the promise error (case 1.) on the upper level to prevent the error to reach the top and polute the browser log.

Question

Should we include the error message returned in the scheduling response in case of error in the toast message?
For now a static Assistant error: Something went wrong when scheduling the task is shown.
I'm wondering because in the specific example I witnessed, the manager validation error is not really meant to be displayed to the user.

@julien-nc julien-nc merged commit dafdab9 into main Dec 17, 2025
9 checks passed
@julien-nc julien-nc deleted the fix/noid/schedule-request-fail branch December 17, 2025 11:35
@janepie janepie mentioned this pull request Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants