Skip to content

Conversation

@marcelklehr
Copy link
Member

Kooha-2025-12-11-15-02-25.webm

These buttons would only be present if context_agent is enabled.

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use tertiary buttons here and a flex layout for the container, wrapping them only when there's no available space.

@marcelklehr
Copy link
Member Author

marcelklehr commented Dec 15, 2025

I'd use tertiary buttons here and a flex layout for the container, wrapping them only when there's no available space.

@marcoambrosini Good point! Thanks! What do you think about the general idea?

Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
Copy link
Member Author

Screenshot from 2025-12-15 08-25-14

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering they are hardcoded suggestions, I’d say the first one is better as:

  • What’s the weather tomorrow?

Automatically taking your location from the profile.

And just layout-wise:

  • It would be good to put the suggestions directly above the input field so it’s related
  • Left-align them
  • Display them more as chips, so it seems a bit clickable (I preferred secondary to tertiary, but I get the concern with the nav on the top)

@marcelklehr
Copy link
Member Author

What’s the weather tomorrow?

Agreed. Context agent doesn't offer this, yet, though :S

@jancborchardt
Copy link
Member

jancborchardt commented Dec 16, 2025

Agreed. Context agent doesn't offer this, yet, though :S

Is the problem the "tomorrow" part or the "place" part? Cause we could also do "What’s the weather today?", automatically taking your city from the profile, or asking a follow-up if it’s not set? Would just be strange if we hardcode "Berlin".

@marcelklehr
Copy link
Member Author

"What’s the weather today?", automatically taking your city from the profile

Yep, we can do that :)

@marcelklehr
Copy link
Member Author

@marcoambrosini mentioned that it might be nice to group suggested prompts by categories (maybe apps?) and only display the category names in the buttons, instead of the full prompts

@jancborchardt
Copy link
Member

@marcoambrosini mentioned that it might be nice to group suggested prompts by categories (maybe apps?) and only display the category names in the buttons, instead of the full prompts

Yeah, we talked about that (also e.g. vertically aligning the input field on emptycontent, like others do) – but I would recommend to tackle this step by step to prevent blocking or overloading this. Let’s get this adjusted and in, and then continue to the next PR.

Does that make sense @marcelklehr? :)

@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Dec 16, 2025
@marcelklehr
Copy link
Member Author

In my humble opinion, the NcChip compomnent looked worse and was less a11y friendly. So I stuck to the tertiary buttons for now:

Screenshot from 2025-12-22 09-22-56 Screenshot from 2025-12-22 09-24-24

@marcelklehr marcelklehr moved this from 🏗️ At engineering to 📐 At design in 🖍 Design team Dec 22, 2025
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, let's go with this and then we can continue with the other changes @marcoambrosini and you suggested. :)

@marcelklehr marcelklehr merged commit 8cd270b into main Dec 22, 2025
17 checks passed
@marcelklehr marcelklehr deleted the feat/agency-indicator branch December 22, 2025 10:26
@github-project-automation github-project-automation bot moved this from 📐 At design to 🎉 Done in 🖍 Design team Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

4 participants