Skip to content

Conversation

@jorlandobr
Copy link
Contributor

Template and test files for Cisco XR command show running-config interface.

@mjbear mjbear changed the title Add template cisco_xr_show_running-config_interface.textfsm Add cisco_xr_show_running-config_interface Nov 18, 2025
@mjbear mjbear added question changes_requested Waiting on user to address feedback labels Nov 18, 2025
@jorlandobr
Copy link
Contributor Author

Modifications applied, tests ok!

@mjbear mjbear added the WIP Work in Progress label Nov 20, 2025
- Normalize to NETMASK
- Change file format/line ending to unix format
- Make capture groups more self-describing
- Establish an normalization standard
- Add the capture group names to data model
- Update the recording pattern to be the exclamation mark !
- Match the date stamp more (to avoid inadvertent matches)
@mjbear
Copy link
Collaborator

mjbear commented Nov 20, 2025

  • ✅ Normalized IP_NETMASK to NETMASK
  • ✅ Normalized DOT1Q to OUTER_VLAN (added to data_model.md)
  • ✅ Normalized SECOND_DOT1Q to INNER_VLAN (added to data_model.md)
  • ✅ Matched the date stamp more (to avoid inadvertent matches)
  • ✅ Updated the Record pattern to be the exclamation mark !
  • ❓ Since IPv4 addresses, IPv6 addresses, and IPv6 prefix lengths are all plural, we probably should use the plural ones from the data_model.md
    • Though we don't have a standard plural capture group for NETMASK
    • I suppose in retrospect those templates with the plural form could have been the singular form with the expectation that consumers/users would type() check the returned key+value pairs in the dictionary.
    • Thoughts? @jmcgill298 @jvanderaa @matt852

@matt852
Copy link
Contributor

matt852 commented Nov 26, 2025

  • ❓ Since IPv4 addresses, IPv6 addresses, and IPv6 prefix lengths are all plural, we probably should use the plural ones from the data_model.md

    • Though we don't have a standard plural capture group for NETMASK
    • I suppose in retrospect those templates with the plural form could have been the singular form with the expectation that consumers/users would type() check the returned key+value pairs in the dictionary.
    • Thoughts? @jmcgill298 @jvanderaa @matt852

@mjbear I think adding a plural "NETMASKS" to keep it consistent with singluar/plural IP_ADDRESS(ES) is a good idea. I have a separate PR I'm working to update the data models, and can add this suggestion to it.

@mjbear mjbear mentioned this pull request Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes_requested Waiting on user to address feedback question WIP Work in Progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants