-
Notifications
You must be signed in to change notification settings - Fork 783
Add cisco_xr_show_running-config_interface #2241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jorlandobr
wants to merge
23
commits into
networktocode:master
Choose a base branch
from
jorlandobr:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt852
requested changes
Nov 17, 2025
ntc_templates/templates/cisco_xr_show_running-config_interface.textfsm
Outdated
Show resolved
Hide resolved
ntc_templates/templates/cisco_xr_show_running-config_interface.textfsm
Outdated
Show resolved
Hide resolved
ntc_templates/templates/cisco_xr_show_running-config_interface.textfsm
Outdated
Show resolved
Hide resolved
ntc_templates/templates/cisco_xr_show_running-config_interface.textfsm
Outdated
Show resolved
Hide resolved
ntc_templates/templates/cisco_xr_show_running-config_interface.textfsm
Outdated
Show resolved
Hide resolved
tests/cisco_xr/show_running-config_interface/cisco_xr_show_running-config_interface.raw
Show resolved
Hide resolved
….textfsm Co-authored-by: matt852 <[email protected]>
….textfsm Co-authored-by: matt852 <[email protected]>
….textfsm Co-authored-by: matt852 <[email protected]>
….textfsm Co-authored-by: matt852 <[email protected]>
mjbear
reviewed
Nov 18, 2025
ntc_templates/templates/cisco_xr_show_running-config_interface.textfsm
Outdated
Show resolved
Hide resolved
mjbear
reviewed
Nov 18, 2025
ntc_templates/templates/cisco_xr_show_running-config_interface.textfsm
Outdated
Show resolved
Hide resolved
mjbear
reviewed
Nov 18, 2025
ntc_templates/templates/cisco_xr_show_running-config_interface.textfsm
Outdated
Show resolved
Hide resolved
….textfsm Co-authored-by: Michael Bear <[email protected]>
Contributor
Author
|
Modifications applied, tests ok! |
- Normalize to NETMASK - Change file format/line ending to unix format
- Make capture groups more self-describing - Establish an normalization standard - Add the capture group names to data model
- Update the recording pattern to be the exclamation mark ! - Match the date stamp more (to avoid inadvertent matches)
Collaborator
|
Contributor
@mjbear I think adding a plural "NETMASKS" to keep it consistent with singluar/plural IP_ADDRESS(ES) is a good idea. I have a separate PR I'm working to update the data models, and can add this suggestion to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template and test files for Cisco XR command
show running-config interface.