Fix HTML bugs, accessibility issues, typos, and styling#1
Open
hilaryduffrules-hash wants to merge 1 commit intomurdawkmedia:masterfrom
Open
Fix HTML bugs, accessibility issues, typos, and styling#1hilaryduffrules-hash wants to merge 1 commit intomurdawkmedia:masterfrom
hilaryduffrules-hash wants to merge 1 commit intomurdawkmedia:masterfrom
Conversation
Critical fixes: - _layouts/default.html: unclosed <div> (was <div> instead of </div>) for .Site wrapper, breaking entire page DOM structure - _layouts/default.html: add lang="en" to <html> element (accessibility) - events.html, blog.html: missing closing </div> for inner post list div Head / meta improvements: - _includes/head.html: add charset=utf-8 meta tag - _includes/head.html: remove user-scalable=no (WCAG accessibility) - _includes/head.html: add display=swap to Google Fonts (prevents FOIT) - _includes/head.html: add per-page description meta tag with excerpt fallback Navigation and layout: - _includes/header.html: use relative / for logo link (was site.github.url) - _includes/header.html: add aria-label to <nav> element - _includes/header.html: add aria-hidden to decorative border div - _includes/footer.html: add aria-hidden to decorative border div - _includes/footer.html: capitalize GitHub correctly - assets/css/_global.scss: responsive nav stacking on small screens Post content styling: - assets/css/_post.scss: add list styling (disc/decimal), blockquote, code/pre blocks — post content was missing these from _reset.scss stripping Content fixes: - about.md: add missing title front matter - about.md: remove references to bitdevsnyc contact email (wrong org) - calendar.md: fix title (was "Meetings", nav says "Calendar") - cities.md: add missing title front matter - cities.md: fix "shoulder's" -> "shoulders" (apostrophe typo) - cities.md: fix Denver and Honolulu links from http:// to https:// - map.md: add missing title front matter - map.md: fix "Miscallaneous" -> "Miscellaneous" (spelling typo) - map.md: fix BTCMap iframe duplicate lat/long params in URL - 404.html: improve with helpful nav links back to home and events - _posts/2023-02-27: fix broken LocalBitcoins link (unclosed parenthesis)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a collection of real bugs, accessibility issues, typos, and content problems found across the site.
Critical HTML Bugs
_layouts/default.html: The closing tag for the.Sitewrapper was<div>instead of</div>, breaking the entire page DOM for every page on the site.events.html,blog.html: Missing closing</div>for the inner post list container, producing malformed HTML.Accessibility
_includes/head.html: Removeduser-scalable=nofrom the viewport meta tag — this violates WCAG 1.4.4 and prevents users who need to zoom from doing so._layouts/default.html: Addedlang="en"to the<html>element (required for screen readers and SEO)._includes/header.html: Addedaria-label="Main navigation"to the<nav>element; addedaria-hidden="true"to the decorative ASCII border<div>._includes/footer.html: Addedaria-hidden="true"to the decorative ASCII border<div>.Head / Meta Improvements
_includes/head.html: Added<meta charset="utf-8">(was missing entirely)._includes/head.html: Added per-page<meta name="description">usingpage.excerptwith fallback to site tagline._includes/head.html: Addeddisplay=swapto the Google Fonts URL, preventing Flash of Invisible Text (FOIT).Navigation
_includes/header.html: Logo link was usingsite.github.urlwhich can resolve incorrectly in some build environments. Changed to/(root-relative).Post Content Styling
assets/css/_post.scss: The CSS reset (_reset.scss) strips all list styling, but_post.scsshad no overrides — meaning bullet/numbered lists in post content rendered with no visual markers. Added properdisc/decimallist styles, blockquote styling, andcode/preblock styling (matching the pattern already used in_blog.scss).assets/css/_global.scss: Added responsive nav stacking for very small screens (< 400px) so the title and nav links don't collide.Content Fixes
about.md: Added missingtitlefront matter. Removed two references tobitdevsnyc at gmail— this is the Vancouver site, not NYC.calendar.md: Fixed page title from "Meetings" to "Calendar" (consistent with nav label).cities.md: Added missingtitlefront matter. Fixed apostrophe typo: "shoulder's of giants" → "shoulders of giants". Fixed Denver and Honolulu URLs fromhttp://tohttps://.map.md: Added missingtitlefront matter. Fixed spelling: "Miscallaneous" → "Miscellaneous". Fixed the BTCMap iframesrcURL which had duplicatelatandlongquery parameters (a URL with twolatvalues is invalid; the last one wins unpredictably).404.html: Improved 404 page with helpful links back to home and events._posts/2023-02-27-vancouver-socratic-10.md: Fixed broken link for "Localbitcoins shutting down" — the URL had an unclosed parenthesis causing the Markdown parser to break the link._includes/footer.html: Capitalized "GitHub" correctly (was "Github").