Community Health: Obsolete resources and corresponding entities#3965
Open
functionzz wants to merge 6 commits intomozilla:mainfrom
Open
Community Health: Obsolete resources and corresponding entities#3965functionzz wants to merge 6 commits intomozilla:mainfrom
functionzz wants to merge 6 commits intomozilla:mainfrom
Conversation
functionzz
changed the title
functionzz
changed the title
mathjazz
reviewed
Feb 13, 2026
Collaborator
mathjazz
left a comment
mathjazz
left a comment
There was a problem hiding this comment.
Nice work!
Please also make sure that everywhere in the code where we references all resources (and count on the fact that obsolete resources are currently not present), we now reference active resources only.
functionzz
commented
Feb 17, 2026
functionzz
commented
Feb 17, 2026
functionzz
commented
Feb 17, 2026
mathjazz
reviewed
Feb 19, 2026
Collaborator
mathjazz
left a comment
mathjazz
left a comment
There was a problem hiding this comment.
Thanks for the update!
This will need extensive testing before we ship it.
Does not delete resources/entities/translated_resources - filters for obsolete strings will be added later
Co-authored-by: Matjaž Horvat <matjaz.horvat@gmail.com>
functionzz
force-pushed
the
obsolete_resources_over_deletion
branch
from
8ee6402 to
92481ce
Compare
Collaborator
Author
|
I guess the next natural step is writing tests for the various cases listed here if everything looks fine. |
Collaborator
That would be great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the data loss incurred when someone removes strings from projects like Firefox. Instead of obsoleting the strings, we currently delete the data which causes contributior attribution to be lost.
Fixes #2133.