Bug 2019411 - Move update_verify and beetmover_transform from firefox-main to mozilla-taskgraph#174
Open
dandarnell wants to merge 2 commits intomozilla-releng:mainfrom
Open
Bug 2019411 - Move update_verify and beetmover_transform from firefox-main to mozilla-taskgraph#174dandarnell wants to merge 2 commits intomozilla-releng:mainfrom
dandarnell wants to merge 2 commits intomozilla-releng:mainfrom
Conversation
ahal
requested changes
Mar 9, 2026
| generate_artifact_registry_gcs_sources, | ||
| get_beetmover_apt_repo_scope, | ||
| get_beetmover_repo_action_scope, | ||
| ) |
Contributor
There was a problem hiding this comment.
Sadly these imports won't work :)
We'll need to port these over as well or else re-write the transform to be a more focused on just the parts that aren't dependent on other stuff in gecko_taskgraph.
ahal
reviewed
Mar 9, 2026
| from taskgraph.util.copy import deepcopy | ||
| from taskgraph.util.treeherder import add_suffix, inherit_treeherder_from_dep | ||
|
|
||
| from gecko_taskgraph.util.attributes import task_name |
Contributor
There was a problem hiding this comment.
This one needs to be ported as well.. But I think it's a lot simpler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both transforms are used by both Firefox and Thunderbird, so they should be good project-agnostic candidates for migration from firefox-main -> mozilla-taskgraph.
I've also created the relevant patches to point Firefox's and Thunderbird's taskgraphs at mozilla-taskgraph for update_verify and beetmover_apt:
Firefox:
update_verify
beetmover_apt
Thunderbird:
update_verify
beetmover_apt