Add a more robust data table that allows filtering for records#108
Draft
skhamis wants to merge 4 commits intomozilla-extensions:mainfrom
Draft
Add a more robust data table that allows filtering for records#108skhamis wants to merge 4 commits intomozilla-extensions:mainfrom
skhamis wants to merge 4 commits intomozilla-extensions:mainfrom
Conversation
skhamis
force-pushed
the
simple-table-view
branch
from
34582c2 to
2b05171
Compare
skhamis
force-pushed
the
simple-table-view
branch
from
65033d9 to
b4fa5c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will be looking for feedback on this. Decided on https://github.com/TanStack/table as the back-end component since:
However I'm okay with switching components if we feel strongly. It is a bit verbose but gets the job done! I haven't done much in terms of making it look pretty as I want to make sure (1) there is no functionality loss (2) I understand the feature-set better before making any design changes.
Old Table:
New Table:
4e-60251530c99e.png)
Main features: